Refactor: simplify the CLI command addition#6
Open
thoriqadillah wants to merge 6 commits intoanthdm:masterfrom
Open
Refactor: simplify the CLI command addition#6thoriqadillah wants to merge 6 commits intoanthdm:masterfrom
thoriqadillah wants to merge 6 commits intoanthdm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, when we want to make a new command for the cli, we need to extend the switch case, and then manually adding the usage or help command. This can be messy pretty quick. So, i use the cobra library to simplify the command addition for further development
Note: this PR mostly only modify/refactor the current cli approach. There is absolutely room for other improvement, but the intention of this PR solely only to refactor the cli